fix: don't rescope imported names #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
alexander-akait
requested changes
Feb 15, 2019
|
Sorry @evilebottnawi it's not clear where to open an issue for all of these packages broadly. I did try to bring this up for discussion here: css-modules/postcss-modules-values#2 (comment) sorry if i wasn't clear there 👍 |
|
it may be worth consolidating a lot of these small plugins into a single postcss-css-modules monorepo |
|
@jquense i think it is impossible right now due historical reason, let's solve some architecture problem in plugin first and then we can do this |
|
/cc @jquense can you rebase? |
|
i can, tho I think that i may close this one for a different, better approach. I rather than skipping values, it would be better to not scope them as |
|
@jquense 👍 Feel free to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think i would consider this a fix. But maybe we should communicate more explicitly with the values plugin via
resultthe idea here is if you have an imported value, that values identifier shouldn't be changed in the places it was replaced other downstream the right values won't work